Re: [RFC][PATCH RT] acpi/rt: Convert acpi lock back to araw_spinlock_t
From: John Kacur
Date: Wed Feb 13 2013 - 12:46:59 EST
On Wed, 13 Feb 2013, Thomas Gleixner wrote:
> On Wed, 13 Feb 2013, John Kacur wrote:
> > Thanks Steven. That looks way better than the previous revert.
> I can't tell as I haven't seen the previous revert. And looks good is
> not really a good review criteria.
Absolutely true, and I wasn't claiming to have reviewed it, just wanted to
let everyone know that testing on it was to begin.
> The patch is converting _all_ the spin_locks in acpi to raw spinlocks,
> which will give you a nice bunch of "BUG: sleeping function called
> from invalid context" splats depending on the ACPI functionality of
> your machine.
> The lock which is related to this splat is: acpi_gbl_hardware_lock and
> that's the only lock which can be safely converted to a raw spinlock.
> Untested patch below.
Thank you Thomas, adding this version instead to our test queue.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/