Re: [PATCH 1/4] clocksource: pass DT node pointer to init functions

From: Michal Simek
Date: Wed Feb 13 2013 - 12:33:45 EST

2013/2/13 Rob Herring <robherring2@xxxxxxxxx>:
> On 02/13/2013 10:21 AM, Michal Simek wrote:
>> 2013/2/7 Rob Herring <robherring2@xxxxxxxxx>:
>>> From: Rob Herring <rob.herring@xxxxxxxxxxx>
>>> In cases where we have multiple nodes of the same type, we may need the
>>> node pointer to know which node was matched. Passing the node pointer
>>> also keeps the init function from having to match the node a 2nd time.
>>> Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx>
>>> Cc: John Stultz <johnstul@xxxxxxxxxx>
>>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>>> ---
>>> drivers/clocksource/clksrc-of.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> Tested-by: Michal Simek <michal.simek@xxxxxxxxxx>
>> The rest is just the same as I have done. Any option to add these
>> patches to v3.9?
> I would like to before we have more users to fix, but it will have to be
> post rc1. If not, Arnd/Olof should be be able to provide a stable branch
> for 3.10.


>> Because I need these patches for zynq timer because we have two in the soc.
>> Is it OK to register several clock source and clockevent devices?
> If it is 1 DT node, then that should be fine.

zynq is using two triple timer counter IP . There are also described by two
different DT nodes because there are separated and uses different baseaddresses.

Does it mean that if there are 2 DT nodes that it won't work?

One more thing. Is there any rule which should describe which timer should be
used for clockevent and for clocksource?

>> btw: there is still one issue because you can just setup only one
>> compatibility string.
> You can have multiple CLOCKSOURCE_OF_DECLARE statements. The gic code
> does this for irqchips.

Ok. Will look at it.


Michal Simek, Ing. (M.Eng)
w: p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu -
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at