Re: [PATCH 1/4] of/pci: Provide support for parsing PCI DT rangesproperty

[Thierry Reding]

On Wed, Feb 13, 2013 at 08:23:28AM -0600, Rob Herring wrote:
> On 02/12/2013 12:45 AM, Thierry Reding wrote:
> > On Mon, Feb 11, 2013 at 01:43:03PM -0600, Rob Herring wrote:
> >> On 02/11/2013 02:22 AM, Thierry Reding wrote:
> >>> From: Andrew Murray <andrew.murray@xxxxxxx>
> 
> >>> @@ -13,6 +13,7 @@
> >>>  #define OF_CHECK_COUNTS(na, ns)	(OF_CHECK_ADDR_COUNT(na) && (ns) > 0)
> >>>  
> >>>  static struct of_bus *of_match_bus(struct device_node *np);
> >>> +static struct of_bus *of_find_bus(const char *name);
> >>
> >> Can you move this function up to avoid the forward declaration.
> > 
> > It needs to be defined after the of_busses structure, which is defined
> > below the CONFIG_PCI block where of_pci_process_ranges() is defined. I'd
> > have to move that one as well and add another #ifdef CONFIG_PCI section.
> > If you prefer that I can do that.
> 
> Okay, it's fine as is.
> 
> >>> +static struct of_bus *of_find_bus(const char *name)
> >>> +{
> >>> +	unsigned int i;
> >>> +
> >>> +	for (i = 0; i < ARRAY_SIZE(of_busses); i++)
> >>> +		if (strcmp(name, of_busses[i].name) == 0)
> >>                                               ^
> >> space needed.
> > 
> > I don't understand. Do you want the space to go between '.' and "name"?
> 
> Must have been some dirt on my screen... Never mind.
> 
> I'll apply these for 3.9.

Great, thanks!

Thierry

Attachment: pgp00000.pgp
Description: PGP signature