Re: [PATCH 2/2] regmap: irq: do not write mask register if it is notsupported

From: Mark Brown
Date: Wed Feb 13 2013 - 09:20:43 EST

On Wed, Feb 13, 2013 at 06:44:50PM +0530, Laxman Dewangan wrote:
> Ignore the mask register write if mask_base is not provided by
> regmap irq client. This is useful when regmap irq framework is
> used for the MFD's gpio interrupt support. Typically, gpio has
> two registers related to interrupt, one is for setting interrupt

Again you're talking about specific devices as though these are generic
things related to the class of device.

> for (i = 0; i < d->chip->num_regs; i++) {
> + if (!d->chip->mask_base)
> + goto skip_mask_reg_update;
> +

Why is this inside the loop?

I'd also expect us to return an error if a caller tries to enable or
disable an interrupt, or possibly to give different ops to the IRQ
subsystem, rather than just silently claim we did what we were asked.

Attachment: signature.asc
Description: Digital signature