Re: [PATCH v3 2/2] ARM: OMAP2+: Export SoC information to userspace

[Ruslan Bilovol]

On Mon, Feb 11, 2013 at 7:56 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Ruslan Bilovol <ruslan.bilovol@xxxxxx> [130206 14:54]:
>> --- a/arch/arm/mach-omap2/io.c
>> +++ b/arch/arm/mach-omap2/io.c
>> @@ -602,6 +602,7 @@ void __init omap4430_init_late(void)
>>       omap2_common_pm_late_init();
>>       omap4_pm_init();
>>       omap2_clk_enable_autoidle_all();
>> +     omap_soc_device_init();
>>  }
>>  #endif
>
> Looks like this should be called for all omaps instead
> of just omap4430?
>
> I suggest you create omap_common_init_late() that
> calls all the common init_late functions:
>
> static void __init omap_common_init_late(void)
> {
>         omap_mux_late_init();
>         omap2_common_pm_late_init();
>         omap_soc_device_init();
> }
>
> Needs to be verified that these really are common to
> all omap2+ though :)

Yes, you are right, currently these functions are common to all
init_late callbacks that we have right now in io.c
I will prepare additional patch soon...

>
> Regards,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/