Re: [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

From: Felipe Balbi
Date: Wed Feb 13 2013 - 03:32:40 EST


On Tue, Feb 12, 2013 at 10:31:00PM -0800, kgene@xxxxxxxxxx wrote:
> Vivek Gautam wrote:
> >
> > Based on 'usb-next'
> >
> > Changes from v4:
> > - Modifying function names and driver names to follow a common
> > naming convention.
> > "usb2phy" for samsung-usb2phy driver
> > "usb3phy" for samsung-usb3phy driver
> > - Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and,
> > "samsung-usb3.c" to "samsung-usb3phy.c"
> > - Removing dependencies for SAMSUNG_USB2PHY and
> > SAMSUNG_USB3PHY.
> > - Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select
> > SAMSUNG_USBPHY,
> > which is the usb-phy helper driver.
> >
> > Vivek Gautam (2):
> > usb: phy: samsung: Common out the generic stuff
> > usb: phy: samsung: Add PHY support for USB 3.0 controller
> >
> > drivers/usb/phy/Kconfig | 25 +-
> > drivers/usb/phy/Makefile | 2 +
> > drivers/usb/phy/samsung-usb2phy.c | 511
> > ++++++++++++++++++++++++++
> > drivers/usb/phy/samsung-usb3phy.c | 349 ++++++++++++++++++
> > drivers/usb/phy/samsung-usbphy.c | 717
> +------------------------------------
> > drivers/usb/phy/samsung-usbphy.h | 328 +++++++++++++++++
> > 6 files changed, 1219 insertions(+), 713 deletions(-)
> > create mode 100644 drivers/usb/phy/samsung-usb2phy.c
> > create mode 100644 drivers/usb/phy/samsung-usb3phy.c
> > create mode 100644 drivers/usb/phy/samsung-usbphy.h
> >
> > --
> > 1.7.6.5
>
> For now, looks good to me, and if any enhancement is required, it can be
> done next time.
>
> Felipe, please go ahead with my ack :-)
> Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>

Thank you, but it's too late for v3.9, this will have to wait until
v3.10. You will get an email once I apply these to my branch.

Cheers

--
balbi

Attachment: signature.asc
Description: Digital signature