RE: [tip:x86/hyperv] X86: Handle Hyper-V vmbus interrupts asspecial hypervisor interrupts
From: KY Srinivasan
Date: Tue Feb 12 2013 - 22:49:51 EST
> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa@xxxxxxxxx]
> Sent: Tuesday, February 12, 2013 10:46 PM
> To: KY Srinivasan
> Cc: Yinghai Lu; mingo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxxxxxxxx; linux-tip-commits@xxxxxxxxxxxxxxx
> Subject: Re: [tip:x86/hyperv] X86: Handle Hyper-V vmbus interrupts as special
> hypervisor interrupts
> On 02/12/2013 07:32 PM, KY Srinivasan wrote:
> >>> +#if IS_ENABLED(CONFIG_HYPERV)
> >>> +apicinterrupt HYPERVISOR_CALLBACK_VECTOR \
> >>> + hyperv_callback_vector hyperv_vector_handler
> >>> +#endif /* CONFIG_HYPERV */
> >>> +
> >> so #ifdef CONFIG_HYPERV does not work here?
> > The issue was that you could turn on CONFIG_HYPERV without enabling
> > CONFIG_X86_LOCAL_APIC. Peter fixed it.
> He is asking why you are using IS_ENABLED() instead of #ifdef. The
> difference is that IS_ENABLED() works even for modules.
> H. Peter Anvin, Intel Open Source Technology Center
> I work for Intel. I don't speak on their behalf.