Re: [PATCH] ARM: exynos: move exynos4210-combiner to drivers/irqchip

From: Olof Johansson
Date: Tue Feb 12 2013 - 17:52:34 EST

On Tue, Feb 12, 2013 at 04:04:52PM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@xxxxxxxxxxx>
> Exynos boot is broken with commit 0529e315 (ARM: use common irqchip_init
> for GIC init). This commit split the irqchip initialization into 2 calls
> to of_irq_init. This does not work because of_irq_init requires interrupt
> parents to be in the match list.
> Rather than reverting exynos changes, make it do the proper thing by using
> IRQCHIP_DECLARE. This requires moving the combiner code to drivers/irqchip.
> Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx>
> Cc: Kukjin Kim <>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> ---
> I thought there may be other platforms broken in the same way, but I
> checked and exynos is the only one.
> This is based on my gic/vic irqchip branch in arm-soc.

Applied to next/cleanup.

I guess this answers whether anyone boots linux-next regularly on Exynos
hardware. :(

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at