[PATCH linux-next] befs: befs_fill_super(): remove unreachable code

From: Tim Gardner
Date: Tue Feb 12 2013 - 12:35:17 EST

befs_sb->num_blocks is of base type u64 which is the same as sector_t.
Therefore, num_blocks can never be larger then the maximum
value of sector_t.

smatch analysis:

fs/befs/linuxvfs.c:851 befs_fill_super() warn: impossible
condition '(befs_sb->num_blocks > ~(0)) => (0-u64max > u64max)'

Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Cc: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
fs/befs/linuxvfs.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index 2b3bda8..2ce5705 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -848,13 +848,6 @@ befs_fill_super(struct super_block *sb, void *data, int silent)
if (befs_check_sb(sb) != BEFS_OK)
goto unacquire_priv_sbp;

- if( befs_sb->num_blocks > ~((sector_t)0) ) {
- befs_error(sb, "blocks count: %Lu "
- "is larger than the host can use",
- befs_sb->num_blocks);
- goto unacquire_priv_sbp;
- }
* set up enough so that it can read an inode
* Fill in kernel superblock fields from private sb

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/