Re: [PATCH] dw_dmac: add support for Lynxpoint DMA controllers

From: Vinod Koul
Date: Tue Feb 12 2013 - 11:34:59 EST


On Fri, Feb 08, 2013 at 09:25:11AM +0200, Andy Shevchenko wrote:
> On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> >> On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> >>> On 7 February 2013 21:06, Andy Shevchenko
> >>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >>>> From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ...
> >>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >>>
> >>> Looks like Mika is Author and you have your signed-off :)
> >>
> >> In this literally small and clear patch it doesn't matter who is who.
> >
> > I believe it doesn't matter how small or big is the patch, but the author should
> > be there in SOBs too..
> True.
Then in that case you need to re-read Documentation/SubmittingPatches
SOB is also acnowlegement of Origin of the Code, hence mandatory even for single
line of change.
> >
> >> However for sake of equity I could add Mika's signed-off-by as well.
> >>
> >> It should be:
> >> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> >
> > Thanks.
>
> Shall I resend it?
It will fix it up, and thanks to greg now you owe me a beverage :)
>
> --
> With Best Regards,
> Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/