Re: [PATCH v2] sched: fix wrong rq's runnable_avg update with rt task

[Vincent Guittot]

On 12 February 2013 15:53, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Tue, 2013-02-12 at 14:23 +0100, Vincent Guittot wrote:
>>       .set_curr_task          = set_curr_task_idle,
>> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
>> index fc88644..9707092 100644
>> --- a/kernel/sched/sched.h
>> +++ b/kernel/sched/sched.h
>> @@ -877,6 +877,7 @@ extern const struct sched_class idle_sched_class;
>>
>>  extern void trigger_load_balance(struct rq *rq, int cpu);
>>  extern void idle_balance(int this_cpu, struct rq *this_rq);
>> +extern void idle_exit(int this_cpu, struct rq *this_rq);
>>
>>  #else        /* CONFIG_SMP */
>>
>> @@ -884,6 +885,10 @@ static inline void idle_balance(int cpu, struct rq *rq)
>>  {
>>  }
>>
>> +static inline void idle_exit(int this_cpu, struct rq *this_rq)
>> +{
>> +}
>> +
>
> Is this part needed? I don't see it ever called when !CONFIG_SMP.

no I forgot to remove it

Vincent
>
> -- Steve
>
>>  #endif
>>
>>  extern void sysrq_sched_debug_show(void);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/