[PATCH v2 9/9] tty/tty_ldisc.c: use test_and_clear_bit intty_ldisc_close

From: George Spelvin
Date: Tue Feb 12 2013 - 09:54:00 EST


We have a function to test and clear a bit in one step, so use it.

Signed-off-by: George Spelvin <linux@xxxxxxxxxxx>
---
drivers/tty/tty_ldisc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index c578229..4606ab9 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c
@@ -453,8 +453,7 @@ static int tty_ldisc_open(struct tty_struct *tty, struct tty_ldisc *ld)

static void tty_ldisc_close(struct tty_struct *tty, struct tty_ldisc *ld)
{
- WARN_ON(!test_bit(TTY_LDISC_OPEN, &tty->flags));
- clear_bit(TTY_LDISC_OPEN, &tty->flags);
+ WARN_ON(!test_and_clear_bit(TTY_LDISC_OPEN, &tty->flags));
if (ld->ops->close)
ld->ops->close(tty);
}
--
1.8.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/