Re: [PATCH] lpc_sch: Accomodate partial population of the MFD devices

From: Samuel Ortiz
Date: Tue Feb 12 2013 - 05:35:05 EST

Hi Darren,

On Fri, Feb 08, 2013 at 03:20:36PM -0800, Darren Hart wrote:
> The current probe aborts if any of the 3 base address registers are
> disabled. On a TunnelCreek system I am working on, this resulted in the
> SMBIOS and GPIO devices being removed when it couldn't read the base
> address for the watchdog timer.
> This patch accommodates partial population of the lpc_sch_cells array and
> only aborts if all the base address registers are disabled. A max size
> array is allocated and the individual device cells are added to it after
> their base addresses are successfully determined. This simplifies the
> code a bit by removing the need for the separate tunnelcreek cells array
> and combining some of the add/remove logic.
> Signed-off-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>,
> Cc: Denis Turischev <denis@xxxxxxxxxxxxxx>,
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>,
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Signed-off-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
> ---
> drivers/mfd/lpc_sch.c | 148 ++++++++++++++++++++++++--------------------------
> 1 file changed, 70 insertions(+), 78 deletions(-)
Patch applied, thanks.


Intel Open Source Technology Centre
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at