Re: [PATCH 1/5] perf, x86: Add PEBSv2 record support v2

[Ingo Molnar]

* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> Add support for the v2 PEBS format. It has a superset of the v1 PEBS
> fields, but has a longer record so we need to adjust the code paths.

The changelog talks about a 'v2' PEBS format - the code talks 
about 'fmt2':

> +/*
> + * Same as pebs_record_nhm, with two additional fields.
> + */
> +struct pebs_record_fmt2 {

In light of the existing pebs_record_core and pebs_record_nhm 
naming a new perf_record_hsw would be more natural.

Or if numbered versions are used, all PEBS record hardware 
versions should be numbered.

Right now your extension makes it all look pretty inconsistent.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/