Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user()warnings

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> On 02/11/2013 07:33 PM, Linus Torvalds wrote:
> > On Mon, Feb 11, 2013 at 5:37 PM, tip-bot for H. Peter Anvin
> > <hpa@xxxxxxxxx> wrote:
> >>
> >> However, we can declare a bitfield using sizeof(), which is legal
> >> because sizeof() is a constant expression.  This quiets the warning,
> >> although the code generated isn't 100% identical from the baseline
> >> before 96477b4 x86-32: Add support for 64bit get_user():
> > 
> > Christ. This is so ugly that it's almost a work of art.
> 
> :)

A real possibility would be that if this ever breaks in a GCC 
version, or generates some really crappy code, we might get a 
"you got what you asked for" shrug from GCC developers?

It's not like we could start a revolution over that.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/