[PATCH] iommu: making IOMMU sysfs nodes API public

From: Alexey Kardashevskiy
Date: Mon Feb 11 2013 - 23:07:06 EST


Having this patch in a tree, adding new nodes in sysfs
for IOMMU groups is going to be easier.

The first candidate for this change is a "dma-window-size"
property which tells a size of a DMA window of the specific
IOMMU group which can be used later for locked pages accounting.

Signed-off-by: Alexey Kardashevskiy <aik@xxxxxxxxx>
---
drivers/iommu/iommu.c | 19 ++-----------------
include/linux/iommu.h | 20 ++++++++++++++++++++
2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index b0afd3d..58cc298 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -52,22 +52,6 @@ struct iommu_device {
char *name;
};

-struct iommu_group_attribute {
- struct attribute attr;
- ssize_t (*show)(struct iommu_group *group, char *buf);
- ssize_t (*store)(struct iommu_group *group,
- const char *buf, size_t count);
-};
-
-#define IOMMU_GROUP_ATTR(_name, _mode, _show, _store) \
-struct iommu_group_attribute iommu_group_attr_##_name = \
- __ATTR(_name, _mode, _show, _store)
-
-#define to_iommu_group_attr(_attr) \
- container_of(_attr, struct iommu_group_attribute, attr)
-#define to_iommu_group(_kobj) \
- container_of(_kobj, struct iommu_group, kobj)
-
static ssize_t iommu_group_attr_show(struct kobject *kobj,
struct attribute *__attr, char *buf)
{
@@ -98,11 +82,12 @@ static const struct sysfs_ops iommu_group_sysfs_ops = {
.store = iommu_group_attr_store,
};

-static int iommu_group_create_file(struct iommu_group *group,
+int iommu_group_create_file(struct iommu_group *group,
struct iommu_group_attribute *attr)
{
return sysfs_create_file(&group->kobj, &attr->attr);
}
+EXPORT_SYMBOL_GPL(iommu_group_create_file);

static void iommu_group_remove_file(struct iommu_group *group,
struct iommu_group_attribute *attr)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index f3b99e1..6d24ba7 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -21,6 +21,7 @@

#include <linux/errno.h>
#include <linux/types.h>
+#include <linux/stat.h>

#define IOMMU_READ (1)
#define IOMMU_WRITE (2)
@@ -197,6 +198,25 @@ static inline int report_iommu_fault(struct iommu_domain *domain,
return ret;
}

+struct iommu_group_attribute {
+ struct attribute attr;
+ ssize_t (*show)(struct iommu_group *group, char *buf);
+ ssize_t (*store)(struct iommu_group *group,
+ const char *buf, size_t count);
+};
+
+#define IOMMU_GROUP_ATTR(_name, _mode, _show, _store) \
+struct iommu_group_attribute iommu_group_attr_##_name = \
+ __ATTR(_name, _mode, _show, _store)
+
+#define to_iommu_group_attr(_attr) \
+ container_of(_attr, struct iommu_group_attribute, attr)
+#define to_iommu_group(_kobj) \
+ container_of(_kobj, struct iommu_group, kobj)
+
+extern int iommu_group_create_file(struct iommu_group *group,
+ struct iommu_group_attribute *attr);
+
#else /* CONFIG_IOMMU_API */

struct iommu_ops {};
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/