Re: [PATCH] staging: Remove unnecessary OOM messages

From: Greg KH
Date: Mon Feb 11 2013 - 13:14:35 EST


On Mon, Feb 11, 2013 at 09:41:29AM -0800, Joe Perches wrote:
> alloc failures already get standardized OOM
> messages and a dump_stack.
>
> For the affected mallocs around these OOM messages:
>
> Converted kzallocs with multiplies to kcalloc.
> Converted kmallocs with multiplies to kmalloc_array.
> Converted a kmalloc/strlen/strncpy to kstrdup.
> Moved a spin_lock below a removed OOM message and
> removed a now unnecessary spin_unlock.
> Neatened alignment and whitespace.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/staging/asus_oled/asus_oled.c | 15 ++-----
> drivers/staging/bcm/InterfaceInit.c | 14 ++----
> drivers/staging/ced1401/usb1401.c | 4 +-
> drivers/staging/comedi/drivers.c | 5 +--
> drivers/staging/comedi/drivers/amplc_dio200.c | 9 ++--
> drivers/staging/comedi/drivers/comedi_bond.c | 5 +--
> drivers/staging/comedi/drivers/dt9812.c | 5 +--
> drivers/staging/comedi/drivers/ni_labpc.c | 10 ++---
> drivers/staging/comedi/drivers/pcmuio.c | 11 ++---
> drivers/staging/comedi/drivers/unioxx5.c | 6 +--
> drivers/staging/comedi/drivers/usbdux.c | 27 ++----------
> drivers/staging/comedi/drivers/usbduxfast.c | 6 ---
> drivers/staging/comedi/drivers/usbduxsigma.c | 31 +++----------
> drivers/staging/cptm1217/clearpad_tm1217.c | 5 +--
> drivers/staging/et131x/et131x.c | 20 +++------
> drivers/staging/frontier/alphatrack.c | 51 +++++++++-------------
> drivers/staging/frontier/tranzport.c | 26 +++++------
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 5 +--
> drivers/staging/gdm72xx/gdm_sdio.c | 8 +---
> drivers/staging/gdm72xx/sdio_boot.c | 9 +---
> drivers/staging/gdm72xx/usb_boot.c | 8 +---
> drivers/staging/iio/accel/lis3l02dq_ring.c | 5 +--
> drivers/staging/keucr/usb.c | 5 +--
> drivers/staging/line6/driver.c | 25 ++---------
> drivers/staging/line6/pcm.c | 6 ---
> drivers/staging/media/as102/as102_usb_drv.c | 4 +-
> drivers/staging/media/go7007/go7007-fw.c | 24 +++-------
> drivers/staging/media/go7007/s2250-loader.c | 5 +--
> drivers/staging/media/lirc/lirc_imon.c | 3 --
> drivers/staging/media/lirc/lirc_sasem.c | 6 ---

I cut the drivers/staging/media/* patches out of this larger patch as
those need to go through Mauro's tree, not mine (they also don't apply
to mine because of that.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/