Re: [PATCH 2/2] zram: gather statistics in a unique file

[Davidlohr Bueso]

On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote:
> On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote:
> > Instead of having one sysfs file per zram statistic, group them all
> > in a single, reader-friendly, 'statistics' file. This not only reduces
> > code but is also makes it easier to visualize. The new file looks like:
> > 
> > Number of reads:        24
> > Number of writes:       1055
> > Invalid IO:             0
> > Notify free:            0
> > Zero pages:             1042
> > Orig data size:         49152 bytes
> > Compressed data:        838 bytes
> > Total memory used:      53248 bytes
> > 
> > Signed-off-by: Davidlohr Bueso <davidlohr.bueso@xxxxxx>
> 
> No, please, the rule for sysfs is "one value per file", not files with
> lots of data that you need to parse.

Ok.

> 
> If you want to do something like this, then do it in debugfs, but NEVER
> in sysfs.

So, you would you be open to having the statistics file in debugfs and
removing the individual files sysfs?

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/