RE: [PATCH V2] Regulator: Reorder the min max assignment in thesequence of regulator_set_voltage function
From: J, KEERTHY
Date: Mon Feb 11 2013 - 12:36:33 EST
> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> Sent: Monday, February 11, 2013 10:35 PM
> To: J, KEERTHY
> Cc: linux-kernel@xxxxxxxxxxxxxxx; lgirdwood@xxxxxxxxx
> Subject: Re: [PATCH V2] Regulator: Reorder the min max assignment in
> the sequence of regulator_set_voltage function
> On Mon, Feb 11, 2013 at 12:19:34PM +0530, J Keerthy wrote:
> > The min and max values for regulators are getting assigned before
> > actually the voltage is set. So making sure that min and max values
> > are assigned only if the voltage is successfully set else keeping the
> > last successfully set voltage's min and max values.
> > This is boot tested on OMAP4430 and OMAP4460 boards.
> This seems fine but doesn't apply against topic/core or -next, can you
> please regenerate against topic/core and resend?
Ok. I will rebase.
> > V2: Fixed comment from Mark. Introduced local variables to hold
> > current min and max values.
> Don't include things like this in the changelog, include them after the
> --- as covered in SubmittingPatches.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/