Re: [PATCH v2] gpio: devm_gpio_* support should not depend on GPIOLIB
From: Max Filippov
Date: Mon Feb 11 2013 - 11:50:32 EST
On Mon, Feb 11, 2013 at 6:13 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Sun, Feb 10, 2013 at 5:46 AM, Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
>> On Sat, Jan 19, 2013 at 2:33 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>>> On Fri, Jan 18, 2013 at 8:57 AM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
>>>> Some architectures (e.g. blackfin) provide gpio API without requiring
>>>> GPIOLIB support (ARCH_WANT_OPTIONAL_GPIOLIB). devm_gpio_* functions
>>>> should also work for these architectures, since they do not really
>>>> depend on GPIOLIB.
>>>> Add a new option GPIO_DEVRES (enabled by default) to control the build
>>>> of devres.c. It also removes the empty version of devm_gpio_*
>>>> functions for !GENERIC_GPIO build from linux/gpio.h, and moves the
>>>> function declarations from asm-generic/gpio.h into linux/gpio.h.
>>>> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
>>> OK I removed the old version of the patch and pushed this instead.
>> this patch causes the following errors for xtensa defconfig build:
> Max, can you point us to an xtensa cross-compiler so we can
> figure out where the problem is?
I use the following scripts to build cross-compiler for xtensa:
You'd need to download binutils/gcc/gdb source tarballs with versions
specified in config and then run
$ ./prepare.sh fsf && ./fixup-gdb.sh && ./build.sh fsf
FWIW I see that the issue is caused by building drivers/gpio/devres.c
with CONFIG_GPIOLIB=n. Should I just turn GPIO_DEVRES off too?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/