Re: [PATCH] regmap: debugfs: Add a registers `range' file

From: Dimitris Papastamos
Date: Mon Feb 11 2013 - 08:46:28 EST


On Mon, Feb 11, 2013 at 01:16:41PM +0000, Mark Brown wrote:
> On Mon, Feb 11, 2013 at 10:52:23AM +0000, Dimitris Papastamos wrote:
>
> > +struct regmap_reg_range {
> > + unsigned int start;
> > + unsigned int end;
> > + unsigned int attr;
> > +};
>
> All we ever do with this struct is
>
> > + r.start = c->base_reg;
> > + r.end = c->max_reg;
> > + r.attr = c->reg_attr;
>
> pack it with the contents of a cache entry. Why not just use the cache
> entry directly?

Yea, will fix and re-send.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/