Re: pt_regs leak into userspace (was Re: [PATCH v3 20/71] ARC: Signalhandling)

From: James Hogan
Date: Mon Feb 11 2013 - 06:02:08 EST


Hi Jonas,

On 11/02/13 10:53, Jonas Bonn wrote:
> And now that I think about it some more, I think this is done
> incorrectly in the openrisc arch, too, as the fast-path for
> rt_sigreturn probably only restores the call-clobbered regs.
> sigreturn probably needs to be special-cased to _always_ restore all
> the regs on its way back to userspace. Not for the "signal" case, but
> for the "setcontext" case; but these two are pretty-much
> indistinguishable.

Wouldn't setcontext restore a different stack, so the sigreturn wouldn't
happen until the ucontext is switched back?

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/