Re: [PATCH v2 00/26] x86, irq: support ioapic device hotplug

From: Ingo Molnar
Date: Mon Feb 11 2013 - 04:34:35 EST



* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> Hi,
>
> Current x86 code does not support iapic hotplug yet.

Please give a better high-level description: outline how an
IO-APIC will be hotplugged physically and what changes the
user will experience.

That needs at least 2 paragraphs, not one cursory sentence. Then
should come technical descriptions - but even those need
improvements, please first explain the current status quo, then
explain how that is inadequate for IO-APIC hot-plugging, *then*
only explain what you are doing in the patch ...

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/