Re: [PATCH v3] gpio: vt8500: memory cleanup missing

[Grant Likely]

On Fri, 18 Jan 2013 17:58:22 +1300, Tony Prisk <linux@xxxxxxxxxxxxxxx> wrote:
> This driver is missing a .remove callback, and the fail path on
> probe is incomplete.
> 
> If an error occurs in vt8500_add_chips, gpio_base is not unmapped.
> The driver is also ignoring the return value from this function so
> if a chip fails to register it completes as successful.
> 
> Replaced pr_err with dev_err in vt8500_add_chips since the device is
> available.
> 
> There is also no .remove callback defined so the function is added.
> 
> Signed-off-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>

Applied, thanks.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/