Re: [PATCH 0/7] 3.8-rc regression with pps-ldisc due to 70ece7a731

From: George Spelvin
Date: Sat Feb 09 2013 - 02:06:18 EST

As a followup, testing my fixes has revealed an old bug in the
PPS driver that I'm trying to figure out how to solve.

Basically, pps_unregister_cdev does

device_destroy(pps_class, pps->dev->devt);

And device_destroy ends up calling pps->dev->release,
which is pps_device_destruct, which does

idr_remove(&pps_idr, pps->id);


Now the problem is that the kfree(pps) happens *before* the
cdev_del(&pps->cdev) call, which is Not Good.

I'm trying to figure out The Right Thing to do in this case and include a
fix for that, too. It's not a regression, but it is a fairly serious bug.

Advice gratefully received, but I'll figure it out on my own, if not.
The most obvious kludge is to wrap the pps_unregister_cdev operations
in device_get/device_put, to force the release callback to be delayed
until later.

I'm hoping for something prettier, though. The other option I'm thinking
about is to move one or both deallocations to the (currently stub)
pps_cdev_release function.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at