Re: [PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar_msi withlocal node

From: Don Dutile
Date: Fri Feb 08 2013 - 15:46:13 EST

On 02/08/2013 02:28 PM, Yinghai Lu wrote:
iommu irq's irq_desc should be on local node ram.

Fix the return value checking problem.

create_irq() will return -1 when fail to allocate.
create_irq_nr() will return 0 when fail to allocate.

here only check !irq, so need to change it to use create_irq_nr instead.

Signed-off-by: Yinghai Lu<yinghai@xxxxxxxxxx>
Cc: Joerg Roedel<joro@xxxxxxxxxx>
Cc: Donald Dutile<ddutile@xxxxxxxxxx>
drivers/iommu/dmar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 174bb65..316b5a2 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -1263,7 +1263,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
if (iommu->irq)
return 0;

- irq = create_irq();
+ irq = create_irq_nr(0, iommu->node);
if (!irq) {
pr_err("IOMMU: no free vectors\n");
return -EINVAL;
Good catch!

you can add my ack to it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at