Re: [PATCH 2/3] regulator: s5m8767: Fix using wrong dev argument atvarious places

From: Mark Brown
Date: Fri Feb 08 2013 - 06:20:35 EST

On Wed, Feb 06, 2013 at 10:56:52AM +0800, Axel Lin wrote:

> Use &pdev->dev rather than iodev->dev for dev_err(), dev_warn() and dev_info().

It's not clear to me that this is actually an improvement, the pdev is
mostly just an internal Linux implementation detail so it's common to
use the physical device for MFD logging in order to help the user
understand what's causing the log message.

> Use &pdev->dev rather than iodev->dev for devm_kzalloc() and
> of_get_regulator_init_data(), this fixes memory leak.

This is a good fix though. This sort of thing is one reason for
splitting out unrelated changes.

Attachment: signature.asc
Description: Digital signature