Re: [PATCH v2 7/7] spi: spi-fsl-spi: Add support for gpio chipselectsfor GRLIB type cores

[Andreas Larsson]

On 2013-02-07 17:08, Anton Vorontsov wrote:
> On Thu, Feb 07, 2013 at 02:12:11PM +0100, Andreas Larsson wrote:
> >   	struct fsl_spi_reg *reg_base;
> > -	int retval;
> > +	int retval, desel;
>
> We don't usually place variable declarations on the same line, unless the
> variables are closely related.
>
> >   	u32 hw_mode;
> >   	struct spi_mpc8xxx_cs	*cs = spi->controller_state;
> >
> > @@ -456,12 +456,45 @@ static int fsl_spi_setup(struct spi_device *spi)
> >   		return retval;
> >   	}
> >
> > +	if (mpc8xxx_spi->type == TYPE_GRLIB) {
> > +		if (gpio_is_valid(spi->cs_gpio)) {
>
> <- You can place the 'int desel;' here, limiting the visibility for it.

Thanks for the feedback!

I'll put that in v3. This last patch needs to wait for the other 
patchset I mentioned anyway.

Cheers,
Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/