RE: [PATCH v3] usb: phy: moving all PHY API definitions to usb/phydirectory

[Venu Byravarasu]

> -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Stephen Warren
> Sent: Thursday, February 07, 2013 10:26 PM
> To: kishon
> Cc: Venu Byravarasu; balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3] usb: phy: moving all PHY API definitions to usb/phy
> directory
> 
> On 02/07/2013 06:38 AM, kishon wrote:
> > On Thursday 07 February 2013 05:02 PM, Venu Byravarasu wrote:
> >> As drivers/usb/otg/otg.c contains most of the PHY related APIs which
> >> are not OTG specific, moving them to more logical place under
> >> drivers/usb/phy.
> 
> >> diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
> >> index b13faa1..886be13 100644
> >> --- a/drivers/usb/phy/Makefile
> >> +++ b/drivers/usb/phy/Makefile
> >> @@ -4,6 +4,7 @@
> >>
> >>   ccflags-$(CONFIG_USB_DEBUG) := -DDEBUG
> >>
> >> +obj-$(CONFIG_USB_COMMON)            += phy.o
> >
> > I think we should have a separate config for PHYs. There might be
> > controllers which dont need separate PHY. But we can have that as a
> > separate patch later since we might want to change the Kconfig of other
> > UDC drivers.

Thanks Kishon for review comments.
Agree to your comments that we can add a new config for PHY & push it in a separate patch. 

> 
> >> +/*
> >> + * phy.c -- USB PHY utility code
> >> + *
> >> + * Copyright (C) 2004 Texas Instruments
> >
> > You can update this to 2013.
> 
> I'm not sure if anyone other that TI can do that?
> 
> >> +EXPORT_SYMBOL_GPL(usb_bind_phy);
> >> +
> >> +
> >
> > Unnecessary spaces here.
> 

Will remove them in next patch update. 

> Thanks for the review. It was very difficult to find you review comments
> since you quoted the entire patch rather than just the few pieces you
> were commenting on...
> 
> > You might want to do this patch after applying *[PATCH] usb: otg: use
> > try_module_get in all usb_get_phy functions and add missing module_put*
> > by Marc.
> 
> Venu, please make sure you include the changes in that patch in your
> Tegra USB/PHY driver rework too, before you post it upstream.

Sure Stephen, thanks for your comments.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/