RE: [PATCH V3] drm_crtc: check if fb_create return NULL

From: Su, Xuemin
Date: Wed Jan 30 2013 - 19:55:30 EST




-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@xxxxxxxxxxxxxxx]
Sent: Thursday, January 24, 2013 5:05 PM
To: Su, Xuemin
Cc: airlied@xxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; yanmin_zhang@xxxxxxxxxxxxxxx; He, Bo
Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL

>Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
>BUG_ON() is making it clear what's expected of the drivers.

>Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Do you think this patch is still needed?
Currently I fix a buggy function radeon_user_framebuffer_create() which returns NULL and patch is added to 3.7-stable tree.
Do you think it's also needed to do something in drm_mode_addfb()?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/