Re: [PATCH V3] drm_crtc: check if fb_create return NULL

[Jani Nikula]

On Thu, 24 Jan 2013, "Su, Xuemin" <xuemin.su@xxxxxxxxx> wrote:
> On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote:
>> >  	}
>> > +	/* some buggy driver may return NULL here, which may cause panic */
>> > +	BUG_ON(!fb);
>> 
>> I fail to see the benefit of this compared to just letting it oops...
>> 
>> >  	or->fb_id = fb->base.id;
>> 
>> ...right here.
>> 
>> 
> For PATCH V3, I think a BUG_ON may give the user clearer information
> about the reason of panic. Easier to debug.

Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
BUG_ON() is making it clear what's expected of the drivers.

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/