Re: [PATCH 12/33] Input: Convert to devm_ioremap_resource()

[Thierry Reding]

On Mon, Jan 21, 2013 at 04:15:35PM +0530, Viresh Kumar wrote:
> On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
> <thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
> > diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
> > @@ -228,11 +228,9 @@ static int spear_kbd_probe(struct platform_device *pdev)
> >                 kbd->suspended_rate = pdata->suspended_rate;
> >         }
> >
> > -       kbd->io_base = devm_request_and_ioremap(&pdev->dev, res);
> > -       if (!kbd->io_base) {
> > -               dev_err(&pdev->dev, "request-ioremap failed for kbd_region\n");
> 
> I would like to keep this error message as is.

Can you specify why? devm_request_and_ioremap() and the new
devm_ioremap_resource() both already output an error message if they
can't request or ioremap the memory region, so all this does is output a
duplicate error message.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature