Re: [PATCH 12/33] Input: Convert to devm_ioremap_resource()

[Viresh Kumar]

On Mon, Jan 21, 2013 at 3:39 PM, Thierry Reding
<thierry.reding@xxxxxxxxxxxxxxxxx> wrote:
> diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
> @@ -228,11 +228,9 @@ static int spear_kbd_probe(struct platform_device *pdev)
>                 kbd->suspended_rate = pdata->suspended_rate;
>         }
>
> -       kbd->io_base = devm_request_and_ioremap(&pdev->dev, res);
> -       if (!kbd->io_base) {
> -               dev_err(&pdev->dev, "request-ioremap failed for kbd_region\n");

I would like to keep this error message as is.

> -               return -ENOMEM;
> -       }
> +       kbd->io_base = devm_ioremap_resource(&pdev->dev, res);
> +       if (IS_ERR(kbd->io_base))
> +               return PTR_ERR(kbd->io_base);

apart from that, for SPEAr

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/