[PATCH] drm/radeon: fix evergreen brightness control regression

From: Eldad Zack
Date: Sun Jan 13 2013 - 15:14:08 EST


Commit 0ecebb9e0d14e9948e0b1529883a776758117d6f introduced a
regression, where using ACPI brightness control leads to a
hard system lock-up.
To resolve the issue, this patch moves the GUI_ACTIVE test
earlier, as it was before the commit.

Signed-off-by: Eldad Zack <eldad@xxxxxxxxxxxxxxx>
---
drivers/gpu/drm/radeon/evergreen.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c
index 061fa0a..1392f99 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -2310,9 +2310,6 @@ static void evergreen_gpu_soft_reset_gfx(struct radeon_device *rdev)
{
u32 grbm_reset = 0;

- if (!(RREG32(GRBM_STATUS) & GUI_ACTIVE))
- return;
-
dev_info(rdev->dev, " GRBM_STATUS = 0x%08X\n",
RREG32(GRBM_STATUS));
dev_info(rdev->dev, " GRBM_STATUS_SE0 = 0x%08X\n",
@@ -2404,6 +2401,9 @@ static int evergreen_gpu_soft_reset(struct radeon_device *rdev, u32 reset_mask)
if (reset_mask == 0)
return 0;

+ if (!(RREG32(GRBM_STATUS) & GUI_ACTIVE))
+ return 0;
+
dev_info(rdev->dev, "GPU softreset: 0x%08X\n", reset_mask);

evergreen_mc_stop(rdev, &save);
--
1.7.12.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/