Re: if_bridge.h: include in6.h for struct in6_addr use

From: Thomas Backlund
Date: Sun Jan 13 2013 - 15:05:53 EST


Thomas Backlund skrev 13.1.2013 20:38:
patch both inline and attached as thunderbird tends to mess up ...

-----

if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
header.

Found by trying to build libvirt and connman against 3.8-rc3 headers.


Ok,
ignore this patch, it's not the correct fix as it introduces
redefinitions...

Btw, the error that I hit that made me suggest this fix was libvirt
config check bailing out:

config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has incomplete type

Reported-by: Colin Guthrie <colin@xxxxxxxxxx>
Reported-by: Christiaan Welvaart <cjw@xxxxxxxxxxxxxxxxx>
Signed-off-by: Thomas Backlund <tmb@xxxxxxxxxx>

--

diff -Nurp linux-3.8-rc3/include/uapi/linux/if_bridge.h
linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h
--- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13
20:09:54.257271755 +0200
+++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13
20:15:04.153676151 +0200
@@ -14,6 +14,7 @@
#define _UAPI_LINUX_IF_BRIDGE_H

#include <linux/types.h>
+#include <linux/in6.h>

#define SYSFS_BRIDGE_ATTR "bridge"
#define SYSFS_BRIDGE_FDB "brforward"


-----
Thomas

--
Thomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/