Re: [PATCH] forcedeth: Fix WARNINGS that result when DMA mappingis not checked

[Eric Dumazet]

On Thu, 2012-12-27 at 14:38 -0600, Larry Finger wrote:
> On 12/27/2012 02:05 PM, Eric Dumazet wrote:
> > On Thu, 2012-12-27 at 13:42 -0600, Larry Finger wrote:

> >> +		if (pci_dma_mapping_error(np->pci_dev,
> >> +					  np->put_tx_ctx->dma))
> >> +			return NETDEV_TX_BUSY;
> >
> > Really this is not going to work very well : caller will call this in a
> > loop.
> 
> Any suggestions on what value should be returned, or does the caller need to be 
> modified?

NETDEV_TX_BUSY is really obsolete

Documentation/networking/driver.txt

In case of mapping error, I would drop the packet.

(kfree_skb() it, increment a device tx_dropped counter,  and return
NETDEV_TX_OK)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/