Re: [PATCH] cgroup: remove redundant check

From: Sasha Levin
Date: Thu Dec 20 2012 - 14:25:00 EST

On 12/20/2012 02:18 PM, Tejun Heo wrote:
> On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote:
>> We already know that 'event' is non-NULL, remove the redundant check.
>> Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>
> I don't know. I kinda like that test there. It's not an error path
> and tearing down everything which could have been allocated. If the
> test not being used is bothering, convert return -ENOMEM to goto fail?

Can't say it's bothering. If you'd prefer to leave it as is I'm okay with
doing that.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at