Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

From: Russell King - ARM Linux
Date: Thu Dec 20 2012 - 14:24:51 EST

On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote:
> On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > Some platforms provide clocks which require enabling before the
> > SMSC911x chip will power on. This patch uses the new common clk
> > framework to do just that. If no clock is provided, it will just
> > be ignored and the driver will continue to assume that no clock
> > is required for the chip to run successfully.
> >
> > Cc: Steve Glendinning <steve.glendinning@xxxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> Seems to me like it'll do the trick.
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

This looks fairly dangerous. What about those platforms which use this
driver, but don't provide a clock for it?

It looks like this will result in those platforms losing their ethernet
support. There's at least a bunch of the ARM evaluation boards which
make use of this driver...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at