Re: [PATCH V4 3/3] MCE: fix an error of mce_bad_pages statistics

From: Xishi Qiu
Date: Wed Dec 12 2012 - 05:47:46 EST


On 2012/12/12 18:25, Borislav Petkov wrote:

> On Wed, Dec 12, 2012 at 11:35:33AM +0800, Xishi Qiu wrote:
>> Since MCE is an x86 concept, and this code is in mm/, it would be
>> better to use the name num_poisoned_pages instead of mce_bad_pages.
>>
>> Signed-off-by: Xishi Qiu <qiuxishi@xxxxxxxxxx>
>> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
>> Signed-off-by: Borislav Petkov <bp@xxxxxxxxx>
>
> This is not how Signed-of-by: works. You should read
> Documentation/SubmittingPatches (yes, the whole of it) about how that
> whole S-o-b thing works.
>
> And, FWIW, it should be "Suggested-by: Borislav Petkov <bp@xxxxxxxxx>"
>
> Thanks.
>

Sorry, I will pay more attention to it next time, thank you. :>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/