Re: [PATCH 15/16] mm: use vm_unmapped_area() on sparc32 architecture

[Rik van Riel]

On 11/05/2012 08:25 PM, David Miller wrote:
> From: Michel Lespinasse <walken@xxxxxxxxxx>
> Date: Mon,  5 Nov 2012 14:47:12 -0800
>
> > Update the sparc32 arch_get_unmapped_area function to make use of
> > vm_unmapped_area() instead of implementing a brute force search.
> >
> > Signed-off-by: Michel Lespinasse <walken@xxxxxxxxxx>
>
> Hmmm...
>
> > -	if (flags & MAP_SHARED)
> > -		addr = COLOUR_ALIGN(addr);
> > -	else
> > -		addr = PAGE_ALIGN(addr);
>
> What part of vm_unmapped_area() is going to duplicate this special
> aligning logic we need on sparc?

That would be this part:

+found:
+	/* We found a suitable gap. Clip it with the original low_limit. */
+	if (gap_start < info->low_limit)
+		gap_start = info->low_limit;
+
+	/* Adjust gap address to the desired alignment */
+	gap_start += (info->align_offset - gap_start) & info->align_mask;
+
+	VM_BUG_ON(gap_start + info->length > info->high_limit);
+	VM_BUG_ON(gap_start + info->length > gap_end);
+	return gap_start;
+}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/