Re: [PATCH V3 5/5] Thermal: Add ST-Ericsson DB8500 thermal propertiesand platform data.

[Hongbo Zhang]

On 31 October 2012 10:18, viresh kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On Tue, Oct 30, 2012 at 10:19 PM, hongbo.zhang <hongbo.zhang@xxxxxxxxxx> wrote:
>> From: "hongbo.zhang" <hongbo.zhang@xxxxxxxxxx>
>
> Just a minor comment below.
>
>> This patch adds device tree properties for ST-Ericsson DB8500 thermal driver,
>> also adds the platform data to support the old fashion.
>>
>> Signed-off-by: hongbo.zhang <hongbo.zhang@xxxxxxxxxx>
>
> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
>> ---
>>  arch/arm/boot/dts/dbx5x0.dtsi      | 14 +++++++++
>>  arch/arm/boot/dts/snowball.dts     | 31 ++++++++++++++++++
>>  arch/arm/configs/u8500_defconfig   |  4 +++
>>  arch/arm/mach-ux500/board-mop500.c | 64 ++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 113 insertions(+)
>
>> diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig
>> index cc5e7a8..34918c4 100644
>> --- a/arch/arm/configs/u8500_defconfig
>> +++ b/arch/arm/configs/u8500_defconfig
>> @@ -118,3 +118,7 @@ CONFIG_DEBUG_KERNEL=y
>>  CONFIG_DEBUG_INFO=y
>>  # CONFIG_FTRACE is not set
>>  CONFIG_DEBUG_USER=y
>> +CONFIG_THERMAL=y
>> +CONFIG_CPU_THERMAL=y
>> +CONFIG_DB8500_THERMAL=y
>> +CONFIG_DB8500_CPUFREQ_COOLING=y
>
> Have you entered these manually?? Or used make savedefconfig?
Yes these are added manually, make savedefconfig should be better, but
it seems the original defconfig file are not well generated by
savedefconfig, this file will be changed too much if I use make
savedefconfig. If this is an issue, I will inform the maintainer to
update this.
After consideration, for this time, I will use savedefconfig to find
right places for my configs, discarding the other dis-order ones.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/