Re: [PATCH 7/9] rcu: use this_cpu_ptr per-cpu helper instead ofper_cpu_ptr(p, raw_smp_processor_id())

From: Paul E. McKenney
Date: Wed Oct 31 2012 - 09:36:01 EST


On Wed, Oct 31, 2012 at 09:20:19PM +0800, Shan Wei wrote:
> Paul E. McKenney said, at 2012/10/31 19:51:
> >
> > The first uses smp_processor_id(), which will complain if
> > force_quiescent_state() is called with preemption disabled, which it
> > sometimes is.
> >
> > So what am I missing here?
>
> Hi Paul
>
> this patch is not right for CONFIG_DEBUG_PREEMPT case.
> __this_cpu_ptr is ok which do not check for preemption context.

Ah, got it. Please feel free to submit an updated patch.

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/