Re: [PATCH] usb:musb: Dequeue urbs on device unplug

From: Felipe Balbi
Date: Wed Oct 31 2012 - 09:35:43 EST


hi,

On Mon, Oct 22, 2012 at 06:51:39AM +0200, Virupax SADASHIVPETIMATH wrote:
> > -----Original Message-----
> > From: Felipe Balbi [mailto:balbi@xxxxxx]
> > Sent: Monday, October 15, 2012 5:49 PM
> > To: Virupax SADASHIVPETIMATH
> > Cc: balbi@xxxxxx; stern@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx; linus.walleij@xxxxxxxxxx; Rajaram REGUPATHY;
> > Praveena NADAHALLY
> > Subject: Re: [PATCH] usb:musb: Dequeue urbs on device unplug
> >
> > Hi,
> >
> > On Wed, Oct 10, 2012 at 10:06:03AM +0530, Virupax Sadashivpetimath wrote:
> > > Flush queued urbs on receiving device disconnect interrupt. This is
> > > required for successful disconnect and successive enumeration of the
> > > device.
> > >
> > > In a failure case khubd hangs on usb-storage thread for completion.
> > > Seen in the below trace.
> > >
> > > [ 1355.764526] SysRq : Show Blocked State
> > > [ 1355.768341] task PC stack pid father
> > > [ 1355.773620] khubd D c06a1fbc 0 503 2 0x00000000
> > > [ 1355.780151] [<c06a1fbc>] (__schedule+0x3f0/0x8ec) from [<c06a26a0>]
> > > (schedule+0x58/0x70) [ 1355.788330] [<c06a26a0>] (schedule+0x58/0x70)
> > > from [<c06a2af8>] (schedule_timeout+0x1d8/0x31c) [ 1355.796997]
> > > [<c06a2af8>] (schedule_timeout+0x1d8/0x31c) from [<c06a1994>]
> > > (wait_for_common+0xd8/0x180) [ 1355.806396] [<c06a1994>]
> > > (wait_for_common+0xd8/0x180) from [<c06a1b14>]
> > > (wait_for_completion+0x20/0x24) [ 1355.815887] [<c06a1b14>]
> > I would like to get some Tested-bys here.
>
> Can you please add
>
> Tested-by: <shuai.wen@xxxxxxxxxxxxxx>

as soon as you reply telling me how you tested. Which kind of testcases
did you run ?

thanks

--
balbi

Attachment: signature.asc
Description: Digital signature