Re: [PATCH 5/5] perf tool: Move dso_* related functions into dsoobject

[Arnaldo Carvalho de Melo]

Em Sun, Oct 28, 2012 at 07:42:01PM +0100, Jiri Olsa escreveu:
> On Sun, Oct 28, 2012 at 11:37:02AM -0200, Arnaldo Carvalho de Melo wrote:
> >     CC /home/acme/git/build/perf/util/dso-test-data.o
> > In file included from util/dso.c:2:
> > util/dso.h:87: error: âBUILD_ID_SIZEâ undeclared here (not in a function)
> >     CC /home/acme/git/build/perf/util/color.o
> > cc1: warnings being treated as errors
> > util/dso.c: In function âdso__binary_type_fileâ:
> > util/dso.c:45: error: implicit declaration of function âfilename__read_debuglinkâ
> > util/dso.c:45: error: nested extern declaration of âfilename__read_debuglinkâ
> > util/dso.c:51: error: âsymbol_confâ undeclared (first use in this function)
> > util/dso.c:51: error: (Each undeclared identifier is reported only once
> > util/dso.c:51: error: for each function it appears in.)
> > util/dso.c: In function âdso__deleteâ:
> > util/dso.c:435: error: implicit declaration of function âsymbols__deleteâ
> > util/dso.c:435: error: nested extern declaration of âsymbols__deleteâ
> > util/dso.c: In function âdso__read_running_kernel_build_idâ:
> > util/dso.c:462: error: implicit declaration of function âsysfs__read_build_idâ
> > util/dso.c:462: error: nested extern declaration of âsysfs__read_build_idâ
> > util/dso.c: In function â__dsos__read_build_idsâ:
> > util/dso.c:500: error: implicit declaration of function âfilename__read_build_idâ
> > util/dso.c:500: error: nested extern declaration of âfilename__read_build_idâ
> > util/dso.c: In function âdso__fprintfâ:
> > util/dso.c:589: error: dereferencing pointer to incomplete type
> > util/dso.c:589: error: type defaults to âintâ in declaration of â__mptrâ
> > util/dso.c:589: error: initialization from incompatible pointer type
> > util/dso.c:589: error: invalid use of undefined type âstruct symbolâ
> > util/dso.c:590: error: implicit declaration of function âsymbol__fprintfâ
> > util/dso.c:590: error: nested extern declaration of âsymbol__fprintfâ
> > make: *** [/home/acme/git/build/perf/util/dso.o] Error 1
> 
> ugh.. I have it rebased to your perf/core and it builds cleanly
> 
> Any chance there's something not pushed yet?

The only thing besides the four first patches in your series is one that
you acked:

commit 9175ce1f1244edd9f4d39605aa06ce5b0a50b8e0
Author: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Date:   Fri Oct 26 13:30:06 2012 -0700

    perf tools: Move parse_events error printing to parse_events_options


---------------




[acme@sandy linux]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.3 (Santiago)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/