Re: [PATCH 5/5] perf tool: Move dso_* related functions into dsoobject

[Jiri Olsa]

On Sun, Oct 28, 2012 at 11:37:02AM -0200, Arnaldo Carvalho de Melo wrote:
> Em Sat, Oct 27, 2012 at 11:18:32PM +0200, Jiri Olsa escreveu:
> > Moving dso_* related functions into dso object.
> > 
> > Keeping symbol loading related functions still in the symbol
> > object as it seems more convenient.
> 
> Please resubmit after you fix this: The other 4 patches I already applied to my local tree.
> 
> - Arnaldo
> 
>     CC /home/acme/git/build/perf/util/dso-test-data.o
> In file included from util/dso.c:2:
> util/dso.h:87: error: âBUILD_ID_SIZEâ undeclared here (not in a function)
>     CC /home/acme/git/build/perf/util/color.o
> cc1: warnings being treated as errors
> util/dso.c: In function âdso__binary_type_fileâ:
> util/dso.c:45: error: implicit declaration of function âfilename__read_debuglinkâ
> util/dso.c:45: error: nested extern declaration of âfilename__read_debuglinkâ
> util/dso.c:51: error: âsymbol_confâ undeclared (first use in this function)
> util/dso.c:51: error: (Each undeclared identifier is reported only once
> util/dso.c:51: error: for each function it appears in.)
> util/dso.c: In function âdso__deleteâ:
> util/dso.c:435: error: implicit declaration of function âsymbols__deleteâ
> util/dso.c:435: error: nested extern declaration of âsymbols__deleteâ
> util/dso.c: In function âdso__read_running_kernel_build_idâ:
> util/dso.c:462: error: implicit declaration of function âsysfs__read_build_idâ
> util/dso.c:462: error: nested extern declaration of âsysfs__read_build_idâ
> util/dso.c: In function â__dsos__read_build_idsâ:
> util/dso.c:500: error: implicit declaration of function âfilename__read_build_idâ
> util/dso.c:500: error: nested extern declaration of âfilename__read_build_idâ
> util/dso.c: In function âdso__fprintfâ:
> util/dso.c:589: error: dereferencing pointer to incomplete type
> util/dso.c:589: error: type defaults to âintâ in declaration of â__mptrâ
> util/dso.c:589: error: initialization from incompatible pointer type
> util/dso.c:589: error: invalid use of undefined type âstruct symbolâ
> util/dso.c:590: error: implicit declaration of function âsymbol__fprintfâ
> util/dso.c:590: error: nested extern declaration of âsymbol__fprintfâ
> make: *** [/home/acme/git/build/perf/util/dso.o] Error 1

ugh.. I have it rebased to your perf/core and it builds cleanly

Any chance there's something not pushed yet?

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/