Re: [PATCH] vlan: set sysfs device_type to 'vlan'

[Ben Greear]

On 10/23/2012 03:52 PM, Ben Hutchings wrote:
> On Tue, 2012-10-23 at 09:14 -0700, Ben Greear wrote:
> > On 10/22/2012 11:36 PM, David Miller wrote:
> > > From: Doug Goldstein <cardoe@xxxxxxxxxx>
> > > Date: Mon, 22 Oct 2012 00:53:57 -0500
> > >
> > > > Sets the sysfs device_type to 'vlan' for udev. This makes it easier for
> > > > applications that query network information via udev to identify vlans
> > > > instead of using strrchr().
> > > >
> > > > Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
> > >
> > > You're extremely misguided.  This change, in fact, makes it ten times
> > > harder for such applications to query such devices.
> >
> > If the application doesn't care, it can use the old way (which at least
> > for me, involves string-comparing the driver name ethtool returns, which
> > sucks at best).
>
> The 'old way' that has only worked since Linux 2.6.29 (3.5 years)?
>
> The 'right way' seems to be to query for VLAN information through
> netlink.  But that has only worked since Linux 2.6.23 (5 years ago).
> The real 'old way' is to use SIOCGIFVLAN. :-/

Oh, I have the SIOCGIFVLAN fallback in place too.

But none of this is easy from a shell script, where reading a sysfs
file is quite easy.

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/