Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

[OGAWA Hirofumi]

Namjae Jeon <linkinjeon@xxxxxxxxx> writes:

>> OK, I think I got where is wrong. If it is the subdir of rootdir,
>> fat_dget() should get the inode of root?
> That is correct. Whenever fat_dget() is called for sub-directories
> which is in root folder, we assign root inode as parent inode.
>>
>> So, I guess if parent_logstart == 0, it is BUG().
> Would you explain more why you think it is BUG() ?

Because root dentry is never expired until umount. So, fat_dget()
shouldn't never fail to get inode for subdir of rootdir. Otherwise,
"stale_rw" will not be working in the case even if there is cache.

I.e. I think we don't need to check parent_logstart == 0.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/