Re: REGRESSION: usbdevfs:Use-scatter-gather-lists-for-large-bulk-transfers

From: Henrik Rydberg
Date: Fri Oct 12 2012 - 11:05:12 EST


Hi Alan,

> Instead of introducing a new local variable, why not simply update
> uurb->buffer? That's what we do elsewhere in the code.

It seemed fragile, due to these scary lines:

if (is_in && uurb->buffer_length > 0)
as->userbuffer = uurb->buffer;
else
as->userbuffer = NULL;

I suppose it works in this particular case. How is the
USBDEVFS_URB_TYPE_CONTROL case supposed to work here?

I can certainly change the patch if preferred. Tested and attached
below.

Thanks,
Henrik