Re: [PATCH 27/30] ACPI: EC: Add a quirk for CLEVO M720T/M730Tlaptop

From: Feng Tang
Date: Tue Oct 09 2012 - 02:28:50 EST


Hi Jonathan,

On Tue, 9 Oct 2012 14:16:33 +0800
Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:

> Len Brown wrote:
>
> > By enlarging the GPE storm threshold back to 20, that laptop's
> > EC works fine with interrupt mode instead of polling mode.
>
> What would go wrong if the threshold were just increased to 20 on all
> models?

Then some other platform will stop to work.
https://bugzilla.kernel.org/show_bug.cgi?id=11892

The 26/30 and 27/30 patches are bound together to fix one bug. Some
quote from description from the 26th patch:

ACPI_EC_STORM_THRESHOLD was initially 20 when it's created, and
was changed to 8 in 2.6.28 commit 06cf7d3c7 "ACPI: EC: lower interrupt storm
threshold" to fix kernel bug 11892 by forcing the laptop in that bug to
work in polling mode.

Hope this answers your question.

Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/