Re: [PATCH 4/5] mfd: tps65090: move register access APIs to header

[Laxman Dewangan]

On Monday 08 October 2012 11:07 AM, Venu Byravarasu wrote:
> > -----Original Message-----
> > From: Laxman Dewangan
> > Sent: Sunday, October 07, 2012 8:52 PM
> > To: sameo@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; Venu Byravarasu; Laxman Dewangan
> > Subject: [PATCH 4/5] mfd: tps65090: move register access APIs to header
> >
> > Since tps65090 register is accessed via regmap, moving
> > the register access APIs to header and making it as inline.
> Why should we move function implementation to header file?
> Also by making inline, doesn't the output binary size increase?

These function does not do much but just indirect the regmap calls so 
not seeing much size increase but better execution.
Also it will remove the complexity and code sizes from mfd drivers. The 
sub driver can use direct regmap calls if they want.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/